Catch exceptions when writing compiler results #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various things may go wrong when a user-provided `Compiler` is producing an `Item`. Typically these end up as a `CompilerError` which gets logged and we stop execution. However, due to laziness, it's possible to have a compiler succeed, but return an `Item` that will throw an exception when it's written. This will break the waiting mechanism in the scheduler, causing a `thread blocked indefinitely in an MVar operation` error like in #1014. I added a test case reproducing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various things may go wrong when a user-provided
Compileris producing anItem. Typically these end up as aCompilerErrorwhich gets logged and we stop execution.However, due to laziness, it's possible to have a compiler succeed, but return an
Itemthat will throw an exception when it's written. This will break the waiting mechanism in the scheduler, causing athread blocked indefinitely in an MVar operationerror like in #1014. I added a test case reproducing this.