Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented _.isEq() method. #2507

Closed
wants to merge 1 commit into from
Closed

Implemented _.isEq() method. #2507

wants to merge 1 commit into from

Conversation

aebrow4
Copy link

@aebrow4 aebrow4 commented Apr 20, 2016

Added a SameValueZero check per #2456
Used the same implementation as @jdalton in lodash

_.isEq(a, b) performs a SameValueZero comparison on values a and b.
http://ecma-international.org/ecma-262/6.0/#sec-samevaluezero

_.isEq(a, b) performs a SameValueZero comparison on values a and b.
http://ecma-international.org/ecma-262/6.0/#sec-samevaluezero
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 96.75% when pulling 057633b on aebrow4:master into cb95672 on jashkenas:master.

@megawac
Copy link
Collaborator

megawac commented Apr 20, 2016

Why is an implementation of SameValueZero favourable over an implementation of SameValue?

@jdalton
Copy link
Contributor

jdalton commented Apr 20, 2016

SameValueZero is what Map and Set use so following that allows those to be used internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants