Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial support for constructors #1733

Merged
merged 1 commit into from
Oct 22, 2014

Conversation

megawac
Copy link
Collaborator

@megawac megawac commented Jul 10, 2014

Fixes #1704

Tests semi dependent on #1711

@megawac
Copy link
Collaborator Author

megawac commented Oct 22, 2014

I have a need for this in a project I'm currently working on, anyone have an objection to this change? I'm going to rebase this branch

@jashkenas
Copy link
Owner

What's the performance hit for bound functions with this change? I'd imagine it's considerable.

@megawac
Copy link
Collaborator Author

megawac commented Oct 22, 2014

Partially bound functions or bind bound functions @jashkenas? The logic for bind doesnt change and it still delegates to Function.prototype.bind. The only (non-JIT) hit for partial is an instanceof check

@jashkenas
Copy link
Owner

Sorry — mis-glanced at the diff. Alright then.

jashkenas added a commit that referenced this pull request Oct 22, 2014
@jashkenas jashkenas merged commit 97a54f7 into jashkenas:master Oct 22, 2014
@megawac megawac deleted the partial-constructor branch October 22, 2014 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_.partial support on constructors.
3 participants