Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize split in checkShebangLine #5452

Merged
merged 3 commits into from Sep 8, 2023
Merged

Optimize split in checkShebangLine #5452

merged 3 commits into from Sep 8, 2023

Conversation

Connormiha
Copy link
Contributor

A little optimization. String split has optional second argument to reduce elements count in result array and stop parsing in advance.

@GeoffreyBooth
Copy link
Collaborator

Thanks for this! Can you please update the build output and include that too?

@Connormiha
Copy link
Contributor Author

Thanks for this! Can you please update the build output and include that too?

Done

@GeoffreyBooth GeoffreyBooth merged commit 0f02c50 into jashkenas:main Sep 8, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Connormiha @GeoffreyBooth