Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing content element to onClick param for use in plugins #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sjeiti
Copy link

@Sjeiti Sjeiti commented Mar 23, 2018

execCommand is cool but limited. Having access to the content element in the onClick would really help for plugins. For example, you could do this for a crude deformatter:

         {
           name: 'deformat',
           icon: '<i><del>T</del></i>',
           title: 'Remove formatting',
           result: content => content.textContent += ''
         }

(above works fine but 'input' event should be dispatched manually on content: which is better to handle internally than inside the plugin: ie by boolean return)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants