Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .editorconfig file #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bcolucci
Copy link

It helps contributors to format the code in the same way. Editorconfig is supported by most of the editors/IDE.

@iztsv
Copy link

iztsv commented Mar 21, 2018

@bcolucci what you think about to add prettier also?

@bcolucci
Copy link
Author

@ilyaztsv why not. I just ask myself if for it worth it? I mean, there are just few lines of code right, and maybe an .editorconfig file is enough? What do you think?

@iztsv
Copy link

iztsv commented Mar 21, 2018

@bcolucci thanks for the replay!

Unfortunately, I don't know much editorconfig and supporting it's by IDE's. The good thing of prettier that it automatically (for examples, in precommit hoook) formats code as described in rules. In this way I don't need to worry about how I write code, in any way it will be formatted by prettier as it needs for project.

@Shuunen
Copy link

Shuunen commented Feb 4, 2019

this should be merged :) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants