Update with-loadable-components example #985
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade Babel to v7, Jest to v23.6 Fix the following examples * with-custom-babel-config * with-inferno * with-preact * with-react-native-web * with-rax * Mimic other CRA defaults
* Sync with CRA 2 * Remove unused deps * Remove array
|
Not stale |
|
@fivethreeo I saw you have multiple pull requests on this project, please read #1159 and then send an email to Jared to get permission... |
|
Found a better example: |
|
Will do a new pull request, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recommended way for code splitting with ssr support until lazy and Suspense supports ssr is for the moment @loadable/component. Renamed example to with-loadable-component and removed with-react-loadable since it is now deprecated. Based off the v3.0.0-alpha.2 tag.