Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix value type #3961

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix value type #3961

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
da0c428
fix value type
devcrazygit Mar 14, 2024
eef0a89
add changeset
devcrazygit Mar 14, 2024
39707aa
change condition
devcrazygit Mar 14, 2024
0f1b6aa
fix change set to patch
devcrazygit Apr 22, 2024
4d610a6
Merge branch 'main' of github.com:jaredpalmer/formik into fix/value-type
devcrazygit Apr 22, 2024
733240f
refine type checking
devcrazygit Apr 22, 2024
e70d2ac
Merge branch 'main' into fix/value-type
devcrazygit May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/khaki-cherries-appear.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
'formik': major
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is widening a type a breaking change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quantizor I just walk through changeset tutorial.
What should I put in instead of major? minor is ok?
Or could you write code suggestion here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think probably just a patch is ok

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it. Could you please check?

---

fix to support number and boolean type for form values
4 changes: 2 additions & 2 deletions packages/formik/src/Formik.tsx
View file
Open in desktop
Expand Up @@ -598,7 +598,7 @@ export function useFormik<Values extends FormikValues = FormikValues>({
);

const executeChange = React.useCallback(
(eventOrTextValue: string | React.ChangeEvent<any>, maybePath?: string) => {
(eventOrTextValue: string | number | boolean | React.ChangeEvent<any>, maybePath?: string) => {
// By default, assume that the first argument is a string. This allows us to use
// handleChange with React Native and React Native Web's onChangeText prop which
// provides just the value of the input.
Expand All @@ -607,7 +607,7 @@ export function useFormik<Values extends FormikValues = FormikValues>({
let parsed;
// If the first argument is not a string though, it has to be a synthetic React Event (or a fake one),
// so we handle like we would a normal HTML change event.
if (!isString(eventOrTextValue)) {
if (!isString(eventOrTextValue) && typeof eventOrTextValue !== 'number' && typeof eventOrTextValue !== 'boolean') {
devcrazygit marked this conversation as resolved.
Show resolved Hide resolved
// If we can, persist the event
// @see https://reactjs.org/docs/events.html#event-pooling
if ((eventOrTextValue as any).persist) {
Expand Down