Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: add typing to setFields functions #3824

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kader93t
Copy link

@kader93t kader93t commented Jun 9, 2023

Make setFieldValue fully typed
Make setFieldError, setFieldTouched, validateField filed param typed.

@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2023

⚠️ No Changeset found

Latest commit: f8225cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formik-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2023 4:17am

@mrskiro
Copy link

mrskiro commented Jul 28, 2023

hi, thanks for all the maintenance.
Do you have any plans to have this PR merged? @jaredpalmer

@quantizor
Copy link
Collaborator

Work has been a bit nuts lately, probably will not get to this for a bit sorry. If I find some energy to maintain in my personal time I'll take a look

@quantizor
Copy link
Collaborator

quantizor commented Aug 2, 2023

Started to look into this and I'm not sure it's safe to change outside of semver-major, see some of the component files

@nulldef
Copy link

nulldef commented Aug 2, 2023

I really like the idea, thanks @kader93t!
But unfortunately, it wouldn't work with some features like settings the value by its path, for instance:

setFieldValue('user.email', email)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants