clarify body-parser and LocalStrategy in readme #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bit more detail to the readme around two major stumbling blocks for new users:
LocalStrategy
in the first code example comes frombody-parser
is required for fields to be available inreq.body
, wherepassport-local
expects them.I haven't seen anyone complaining about the former, but it was a bit confusing for me and easy enough to fix as part of this PR.
There's plenty of examples of people having issues with the latter: