Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix E2E tests by changing the list of extra dynamic plugins added to examples/rhdh-cr-with-app-configs.yaml #286

Closed
wants to merge 1 commit into from

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Mar 30, 2024

Description

The plugins from @dfatwork-pkgs/* do not seem to work with the latest version of the Showcase image, as they prevent the Backstage process from starting correctly, making the Backstage pod crash.

Which issue(s) does this PR fix or relate to

PR acceptance criteria

  • Tests
  • Documentation
  • If the bundle manifests have been updated, make sure to review the rhdh-operator.csv.yaml file accordingly

How to test changes / Special notes to the reviewer

  • You need an OpenShift cluster, as we need to check the Routes
  • Before this PR, make test-e2e would not pass because of examples/rhdh-cr-with-app-configs.yaml. Now running make test-e2e should pass.

…rhdh-cr-with-app-configs.yaml

The plugins from '@dfatwork-pkgs' do not seem to work with the latest version of the Showcase image,
as they prevent the Backstage process from starting correctly.
Copy link

openshift-ci bot commented Mar 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rm3l. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarcloud bot commented Mar 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rm3l rm3l requested review from gazarenkov and removed request for jianrongzhang89 March 30, 2024 14:32
Copy link
Collaborator

@gazarenkov gazarenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already addressed in #272
Please target it to 1.1.x

@rm3l
Copy link
Member Author

rm3l commented Apr 2, 2024

It is already addressed in #272 Please target it to 1.1.x

#272 is already big enough ^^, and adding more changes to it makes it even more difficult to review (already 100+ files changed).
Merging simple/independent PRs makes it easier/safer to cherry-pick if needed. You'll be able to rebase #272 once this PR is merged in.

@gazarenkov
Copy link
Collaborator

It is already addressed in #272 Please target it to 1.1.x

#272 is already big enough ^^, and adding more changes to it makes it even more difficult to review (already 100+ files changed). Merging simple/independent PRs makes it easier/safer to cherry-pick if needed. You'll be able to rebase #272 once this PR is merged in.

Well, even if we agreed to consider main as development branch, you requested that it must pass all e2e tests from the very initial state, that's what I am doing.
It is already in PR and I do not think it will take time for you to review just b/c it is your code :)

@rm3l
Copy link
Member Author

rm3l commented Apr 2, 2024

It is already addressed in #272 Please target it to 1.1.x

#272 is already big enough ^^, and adding more changes to it makes it even more difficult to review (already 100+ files changed). Merging simple/independent PRs makes it easier/safer to cherry-pick if needed. You'll be able to rebase #272 once this PR is merged in.

Well, even if we agreed to consider main as development branch, you requested that it must pass all e2e tests from the very initial state, that's what I am doing. It is already in PR and I do not think it will take time for you to review just b/c it is your code :)

Yep, for big PRs, tests help reviewers a lot to check the behavior. But alright, since I saw you cherry-picked the changes here in #272, let's close this one then.
/close

@openshift-ci openshift-ci bot closed this Apr 2, 2024
Copy link

openshift-ci bot commented Apr 2, 2024

@rm3l: Closed this PR.

In response to this:

It is already addressed in #272 Please target it to 1.1.x

#272 is already big enough ^^, and adding more changes to it makes it even more difficult to review (already 100+ files changed). Merging simple/independent PRs makes it easier/safer to cherry-pick if needed. You'll be able to rebase #272 once this PR is merged in.

Well, even if we agreed to consider main as development branch, you requested that it must pass all e2e tests from the very initial state, that's what I am doing. It is already in PR and I do not think it will take time for you to review just b/c it is your code :)

Yep, for big PRs, tests help reviewers a lot to check the behavior. But alright, since I saw you cherry-picked the changes here in #272, let's close this one then.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l rm3l deleted the fix_e2e_tests branch April 2, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants