Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(catalog): added created at column in the catalog page #1257

Merged
merged 1 commit into from
May 15, 2024

Conversation

debsmita1
Copy link
Member

@debsmita1 debsmita1 commented May 14, 2024

Description

  • The PR adds the scaffolder annotator action in the backend
  • In the UI, the catalog page will now show a new Created At column for entity kind Component
  • The new column can be sorted
  • Has E2E test

Which issue(s) does this PR fix

  • Fixes

https://issues.redhat.com/browse/RHIDP-2104
https://issues.redhat.com/browse/RHIDP-2193

Screenshots/GIF

Screenshot 2024-05-14 at 1 42 25 PM

Screenshot 2024-05-14 at 1 33 38 PM

Test setup

Test setup:

  • Changes in app-config.yaml
catalog:
  location:
    # Example template
    - type: url
      target: https://github.com/debsmita1/nodejs-ex-1/blob/master/local-template.yaml
      rules:
        - allow: [Template]
  • Use the Create React App Template with timestamping template to register the entity

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1257!

@subhashkhileri
Copy link
Member

e2e tests changes looks good to me.

@Zaperex
Copy link
Contributor

Zaperex commented May 14, 2024

Tested this PR and the timestamp showed up as expected in the column:
image

Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

@Zaperex
Copy link
Contributor

Zaperex commented May 14, 2024

Tested again and column renders properly for the entities in the catalog with the timestamp annotation.
Components:
image
APIs:
image
Resources:
image
Systems:
image
Templates:
image
Users:
image

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1257!

@ciiay
Copy link
Contributor

ciiay commented May 14, 2024

Tested working great on both local and on OCP 4.14

pr_1257_image.mov
pr_1257_local

Copy link
Contributor

@ciiay ciiay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@invincibleJai
Copy link
Member

/approve

Copy link

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciiay, invincibleJai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c2a414c into janus-idp:main May 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants