Update Yarn, Node and dependencies #1145
Conversation
Update dynamic dependencies with Yarn
Use version 20 of node.js
…the unit tests. Mock-fs was failing to read and test for mocked files.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
For a number of reasons, I'm not sure we want to move to yarn 4 for now. @nickboldt @kadel Do you confirm ? |
Yarn 4 is definitely on our roadmap, but we can't update it right now due to limitations in our build system. We need to resolve those first. |
|
There should not be any external blockers for moving to node 20, but there were some fixable issues. @BethGriggs was looking into that. |
|
Which limitations in the build system? I think I managed to fix all of the local builds and Docker ones? |
|
|
The image is available at: |
|
@davidfestal and @kadel I have fixed the build part now. What do I need to do about getting SonarCloud gate passing as its not really code I have touched. |
There was a problem hiding this comment.
Unfortunately we cannot move to Yarn v4 at this time, for two reasons:
- downstream RHDH build process requires Yarn v1 today and v3 in future
- upstream Backstage community-plugins repo will use Yarn v3, not 4.
Can you revise this PR to use Node 20, but stick with yarn 1.22.22 ?
cc: @schultzp2020
Please be aware that the work of migrating to Node 20 has already been implemented in the following PR: #1048 |
cc @BethGriggs |
|
The whole thing that started me down this path was the large amount of time that it took to build this solution so that I could containerize it. On my work machines with security tools it was taking me 58 minutes to build. I had to remote into my home machine (4th gen nvme, 128GB of ram & Ryzen 5950x) to build anything. Yarn 4 is significantly faster then Yarn 1 on my machine. Have a look at another PR like #1133 it took 31 minutes vs the 17 minutes this one takes for the "PR Docker Build / PR Docker Build (pull_request_target)" step. Steps on GitHub run with hardened mode on as well. For local installs it feels even faster. See https://yarnpkg.com/blog/release/4.0 for section of performance. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
Updated to the Yarn 4.1.1, Node 20 and update package dependencies
Also update Dockerfiles and github workflow steps to use the latest versions.
Needed to update to the latest version of Yarn sytanx
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer