Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): add @smithy/is-array-buffer...chore(deps): add @smithy/is-array-buffer 2.1.1 and util-buffer-from 2.1.1 to make cachito happy with 3scale plugin 1.4.7 #1144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nickboldt
Copy link
Member

@nickboldt nickboldt commented Mar 27, 2024

What does this PR do?

chore(deps): add @smithy/is-array-buffer 2.1.1 and util-buffer-from 2.1.1 to make cachito happy with 3scale plugin 1.4.7

Signed-off-by: Nick Boldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

fix for

2024-03-27 11:56:42,980 - atomic_reactor.tasks.binary_container_build - INFO - error An unexpected error occurred: "https://cachito-nexus.engineering.redhat.com/repository/cachito-yarn-1292208//@smithy/util-buffer-from/-/util-buffer-from-2.1.1.tgz: Request failed \"404 Not Found\"".

same fix as #1143

Once 3scale 1.4.8 is out, we probably don't need this; instad we should remove the smithy 2.1.1 reference.

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

….1.1 to make cachito happy with 3scale plugin 1.4.7

Signed-off-by: Nick Boldt <nboldt@redhat.com>
@nickboldt nickboldt requested a review from a team as a code owner March 27, 2024 15:13
@openshift-ci openshift-ci bot requested review from kadel and Zaperex March 27, 2024 15:13
Copy link

openshift-ci bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from nickboldt. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nickboldt nickboldt changed the title chore(deps): add @smithy/is-array-buffer... chore(deps): add @smithy/is-array-buffer...chore(deps): add @smithy/is-array-buffer 2.1.1 and util-buffer-from 2.1.1 to make cachito happy with 3scale plugin 1.4.7 Mar 27, 2024
@@ -41,6 +41,8 @@
"devDependencies": {
"@backstage/cli": "0.25.2",
"@smithy/util-utf8": "2.1.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once 3scale 1.4.8 is out, this should be removed.

Suggested change
"@smithy/util-utf8": "2.1.1",

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants