Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(renovate): update config to create team specific PRs #1637

Merged
merged 3 commits into from
May 14, 2024

Conversation

kim-tsao
Copy link
Member

@kim-tsao kim-tsao commented May 11, 2024

Fixes: https://issues.redhat.com/browse/RHIDP-2190

  • Added config to group PRs based on github teams (we will rely on CODEOWNERS to auto-assign based on touched files)
  • Auto-merge enabled for minor DevDependencies and Test package updates
  • team/<plugin-team> labels added for grouped PR except for Vulnerability alerts. The additionalBranchPrefix was creating multiple dup PRs (based on unique branch names). I had to reset this value to "" in the VulnerabilityAlerts rule in order to fix this, which means we can't label this. We will rely on CODEOWNERS to assign to the right team in this case. Since most security vulns affect the root yarn.lock file, they should be correctly assigned to the maintainers-plugins team (from CODEOWNERS file)

See test repo for results:
Dashboard
PRs

Signed-off-by: Kim Tsao <ktsao@redhat.com>
Copy link

openshift-ci bot commented May 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from kim-tsao. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@kim-tsao kim-tsao marked this pull request as ready for review May 13, 2024 12:57
@kim-tsao kim-tsao requested a review from a team as a code owner May 13, 2024 12:57
.github/renovate.json Outdated Show resolved Hide resolved
.github/renovate.json Outdated Show resolved Hide resolved
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nickboldt nickboldt added the lgtm label May 14, 2024
@nickboldt nickboldt merged commit 9bf3039 into janus-idp:main May 14, 2024
10 of 11 checks passed
@kim-tsao kim-tsao deleted the renovate branch May 27, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants