feat(rbac): support for updating/deleting conditional permissions

[divyanshiGupta]

Story: https://issues.redhat.com/browse/RHIDP-1878

This PR adds support for updating/deleting existing conditions.

Screen.Recording.2024-05-10.at.7.09.10.PM.mov

[divyanshiGupta]

cc: @ShiranHi

[ShiranHi]

@divyanshiGupta looks good to me!

I've noticed that the edit and delete icons are different colors. Could we please take a look at that?

Also, I'm concerned about the shade of red used here. Could we ensure that both the icon and the button use the PF red color?

[divyanshiGupta]

@divyanshiGupta looks good to me!

I've noticed that the edit and delete icons are different colors. Could we please take a look at that?

Also, I'm concerned about the shade of red used here. Could we ensure that both the icon and the button use the PF red color?

Thanks @ShiranHi

Looks like these are some theme related issues which might get fixed once we have the new theme in place. For now can you log tickets for these issues in jira?

[invincibleJai]

if I understand correctly permission policies and conditional policies are treated differently. So if I only define conditional policies then on the overview screen I see the error as below (earlier it was not possible to create a role without policies but with conditional policies it is)

this doesn't seem good and if policies are not there IMO we should not show errors for 404, @divyanshiGupta WDYT, can address this as part of this PR.

and on the list/overview screen, we are not showing conditional policies. I don't see this in Figma as well so is this based on the design @ShiranHi , we need to think about how can we improve this further

and i observed this issue https://issues.redhat.com/browse/RHIDP-1757 and this needs to be fixed for 1.2

am not sure below why is giving 500

http://localhost:7007/api/permission/authorize

Error:

backend:start: 2024-05-14T08:45:26.598Z backstage error Request failed with status 500 Entity reference "catalog-entity" had missing or empty kind (e.g. did not start with "component:" or similar) type=errorHandler stack=Error: Entity reference "catalog-entity" had missing or empty kind (e.g. did not start with "component:" or similar)
backend:start:     at Object.parseEntityRef (/Users/jakumar/Workspaces/backstage-plugins/node_modules/@backstage/catalog-model/src/entity/ref.ts:110:11)
backend:start:     at <anonymous> (/Users/jakumar/Workspaces/backstage-plugins/node_modules/@backstage/plugin-catalog-backend/src/service/CatalogBuilder.ts:550:49)
backend:start:     at Array.map (<anonymous>)
backend:start:     at getResources (/Users/jakumar/Workspaces/backstage-plugins/node_modules/@backstage/plugin-catalog-backend/src/service/CatalogBuilder.ts:549:33)
backend:start:     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
backend:start:     at <anonymous> (/Users/jakumar/Workspaces/backstage-plugins/node_modules/@backstage/plugin-permission-node/src/integration/createPermissionIntegrationRouter.ts:460:27)

@AndrienkoAleksandr / @PatAKnight is this expected?

[divyanshiGupta]

@invincibleJai I am now not showing error if API returns 404.

[debsmita1]

@divyanshiGupta
I created a role with conditional policies for managing catalog entities. While editing these policies, I deleted the ones for the
catalog and configured access for scaffolder-templates. However, upon saving the changes, an error occurred