Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kiali): traffic graph for cards #1606

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

leandroberetta
Copy link
Contributor

Kiali graph in the entity view (just the card):

image

@leandroberetta leandroberetta requested a review from a team as a code owner May 3, 2024 12:22
@openshift-ci openshift-ci bot requested review from aljesusg and josunect May 3, 2024 12:22
@leandroberetta leandroberetta changed the title feat(kiali): Kiali graph for cards feat(kiali): traffic graph for cards May 3, 2024
Copy link

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kadel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Passed Quality Gate passed

Issues
19 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.5% Duplication on New Code

See analysis details on SonarCloud

@ScriptingShrimp
Copy link
Contributor

Hello @leandroberetta,
since main branch have the playwright tests already fixed, can you please add some regression before merging this PR?
Thank you 🙏

@leandroberetta
Copy link
Contributor Author

Hello @leandroberetta, since main branch have the playwright tests already fixed, can you please add some regression before merging this PR? Thank you 🙏

We decided to merge this as this has been open for a long time. I'm working to add a test in a follow up PR.

@ScriptingShrimp
Copy link
Contributor

Hello @leandroberetta, since main branch have the playwright tests already fixed, can you please add some regression before merging this PR? Thank you 🙏

We decided to merge this as this has been open for a long time. I'm working to add a test in a follow up PR.

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants