Skip to content

Commit

Permalink
set PendingAction correctly for reboot type 1 and 4 packages (fix #94)
Browse files Browse the repository at this point in the history
  • Loading branch information
jantari committed Jul 31, 2023
1 parent 387a208 commit b74ac16
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions public/Install-LSUpdate.ps1
View file
Expand Up @@ -136,8 +136,15 @@
}
} elseif ($PackageToProcess.RebootType -eq 0) {
'NONE'
} elseif ($PackageToProcess.RebootType -eq 1) {
# RebootType 1 updates should force a reboot on their own, interrupting LSUClient anyway,
# but this can lead to race conditions (how fast does the reboot happen, killing LSUClient before this point?)
# or maybe the reboot doesn't happen for some reason so we still communicate that it's needed. See issue #94.
'REBOOT_MANDATORY'
} elseif ($PackageToProcess.RebootType -eq 3) {
'REBOOT_SUGGESTED'
} elseif ($PackageToProcess.RebootType -eq 4) {
'SHUTDOWN'
} elseif ($PackageToProcess.RebootType -eq 5) {
'REBOOT_MANDATORY'
}
Expand Down

1 comment on commit b74ac16

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PSScriptAnalyzer results as of this commit:

  • 3 Information
  • 8 Warning
See details 
Location : ./LSUClient.psm1 [353, 39]
RuleName : TypeNotFound
Severity : Information
Message  : Ignoring 'TypeNotFound' parse error on type 'wmisearcher'. Check if the speci
           fied type is correct. This can also be due the type not being known at parse 
           time due to types imported by 'using' statements.

Location : ./private/Set-BIOSUpdateRegistryFlag.ps1 [1, 10]
RuleName : PSUseShouldProcessForStateChangingFunctions
Severity : Warning
Message  : Function 'Set-BIOSUpdateRegistryFlag' has verb that could change system state
           . Therefore, the function has to support 'ShouldProcess'.

Location : ./private/Compare-Array.ps1 [30, 17]
RuleName : PSReviewUnusedParameter
Severity : Warning
Message  : The parameter 'in' has been declared but not used. 

Location : ./private/Resolve-XMLDependencies.ps1 [1, 10]
RuleName : PSUseSingularNouns
Severity : Warning
Message  : The cmdlet 'Resolve-XMLDependencies' uses a plural noun. A singular noun shou
           ld be used instead.

Location : ./private/Invoke-PackageCommand.ps1 [303, 29]
RuleName : PSAvoidUsingEmptyCatchBlock
Severity : Warning
Message  : Empty catch block is used. Please use Write-Error or throw statements in catc
           h blocks.

Location : ./private/Split-ExecutableAndArguments.ps1 [1, 10]
RuleName : PSUseSingularNouns
Severity : Warning
Message  : The cmdlet 'Split-ExecutableAndArguments' uses a plural noun. A singular noun
            should be used instead.

Location : ./private/Debug-LongRunningProcess.ps1 [44, 13]
RuleName : PSAvoidUsingEmptyCatchBlock
Severity : Warning
Message  : Empty catch block is used. Please use Write-Error or throw statements in catc
           h blocks.

Location : ./private/Debug-LongRunningProcess.ps1 [139, 82]
RuleName : PSReviewUnusedParameter
Severity : Warning
Message  : The parameter 'lParam' has been declared but not used. 

Location : ./public/Install-LSUpdate.ps1 [152, 21]
RuleName : PSUseOutputTypeCorrectly
Severity : Information
Message  : The cmdlet 'Install-LSUpdate' returns an object of type 'PackageInstallResult
           ' but this type is not declared in the OutputType attribute.

Location : ./public/Install-LSUpdate.ps1 [189, 21]
RuleName : PSUseOutputTypeCorrectly
Severity : Information
Message  : The cmdlet 'Install-LSUpdate' returns an object of type 'PackageInstallResult
           ' but this type is not declared in the OutputType attribute.

Location : ./public/Set-LSUClientConfiguration.ps1 [1, 10]
RuleName : PSUseShouldProcessForStateChangingFunctions
Severity : Warning
Message  : Function 'Set-LSUClientConfiguration' has verb that could change system state
           . Therefore, the function has to support 'ShouldProcess'.

Please sign in to comment.