feat: options/positionals with leading '+' and '0' no longer parse as…

… numbers (yargs#1286) BREAKING CHANGE: options with leading '+' or '0' now parse as strings
jameswomack · Feb 2, 2019 · e9dc3aa · e9dc3aa
1 parent ef16792
commit e9dc3aa
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -28,7 +28,7 @@
     "string-width": "^3.0.0",
     "which-module": "^2.0.0",
     "y18n": "^4.0.0",
-    "yargs-parser": "^12.0.0"
+    "yargs-parser": "^13.0.0"
   },
   "devDependencies": {
     "chai": "^4.2.0",

diff --git a/test/command.js b/test/command.js
@@ -1458,4 +1458,11 @@ describe('Command', () => {
       return done()
     })
   })
+
+  // see: https://github.com/yargs/yargs/issues/1099
+  it('does not coerce number from positional with leading "+"', () => {
+    const argv = yargs.command('$0 <phone>', '', (yargs) => {})
+      .parse('+5550100')
+    argv.phone.should.equal('+5550100')
+  })
 })