responseType=blob + string support #109
Conversation
In order to support the `whatwg-fetch` polyfill which sets `responseType='blob'` for every request, create a new Blob when the responseType is `blob` and the body is a string. Added integration tests for `whatwg-fetch` Fixed proxy tests that are failing because the remote services response have changed. `reqres.in` and `httpbin.com` have changed their behavior. Fix those for a working test suite again. Typescript definitions needed some updates in order to pass. Upgraded Typescript to 4.0.
There was a problem hiding this comment.
👋 Hi @statianzo!
Thanks for all the cleanup! Couple minor things to fix and I'm 👍
| @@ -3,6 +3,7 @@ import MockProgressEvent from './MockProgressEvent'; | |||
| import MockXMLHttpRequest from './MockXMLHttpRequest'; | |||
| import {MockRequest} from '.'; | |||
| import {MockError} from './MockError'; | |||
| import {isExportDeclaration} from 'typescript'; | |||
There was a problem hiding this comment.
This import looks unused, was it intentional?
There was a problem hiding this comment.
Probably VSCode being overzealous about auto-imports. I'll get it removed.
| @@ -162,7 +162,7 @@ export default class MockXMLHttpRequest extends MockXMLHttpRequestEventTarget | |||
|
|
|||
| if (this.responseType === 'blob' && typeof body === 'string') { | |||
| try { | |||
| throw notImplementedError; | |||
| return new Blob([body], {type: 'text/plain'}); | |||
There was a problem hiding this comment.
Is Blob provided by whatwg-fetch? Should we continue throwing the error when Blob isn't defined? Not sure if you can think of a clever way to test each case?
There was a problem hiding this comment.
whatwg-fetch doesn't provide Blob. If Blob isn't defined, an error will get thrown and fall back to the return null behavior of the catch. Returning null is the same behavior as when throw notImplementedError was there.
| @@ -22,7 +22,8 @@ export default function( | |||
| const xhr: XMLHttpRequest = new XHRMock.RealXMLHttpRequest(); | |||
|
|
|||
| // TODO: reject with the correct type of error | |||
There was a problem hiding this comment.
Can probably get rid of the TODO: now? 😄
|
Anything else needed for this? |
In order to support the
whatwg-fetchpolyfill which setsresponseType='blob'for every request, create a new Blobwhen the responseType is
bloband the body is a string.Added integration tests for
whatwg-fetchFixed proxy tests that are failing because the remote services response
have changed.
reqres.inandhttpbin.comhave changed their behavior.Fix those for a working test suite again.
Typescript definitions needed some updates in order to pass. Upgraded
Typescript to 4.0.