-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT : Added speech-to-text using Web-Speech-Api, FIX : Added Prettier Formatting #39
Conversation
FIX : Added Prettier Formatting
@MohammedZuhairAhmed is attempting to deploy a commit to the jakobhoeg's projects Team on Vercel. A member of the Team first needs to authorize it. |
Hey, @MohammedZuhairAhmed. Thanks for your contribution. However, I think you'll need to work a bit on the logic. Also I do appreciate the prettier formatting commit. |
Hello @jakobhoeg, The current logic is like this. When we click on the microphone button, the placeholder is updated to 'listening...', and as we speak the same is displayed in the Text area. Then after this we need to disable the microphone by clicking on that button, and send the message. Whenever the microphone is enabled, I have disabled the Text area and when the microphone is disabled you can normally make use of text area with keyboard input as usual |
Hello @jakobhoeg, Regarding the entire div flickering when we hover on the microphone button is happening due to the tailwind hover property When we hover on the button it adds a white border around the div , which takes some extra space so the flickering happens. I will check if I can reduce the border size and eliminate the flickering |
Hello @jakobhoeg, Another notable logic regarding the microphone button is, Let's say the user has typed something in the text area for e.g. "hello, " , then the user may click to provide the remaining input i.e. "How are you" by microphone. So when this happens the current input value "hello, " will be overwritten not appended and will result in only "How are you". This is how the gemini voice input also works so I implemented it in this fashion. If you need append behaviour rather than overwrite, then I can work on this logic also |
Hello @jakobhoeg , could you answer to my questions and get the expectations clarified to work on it? |
Hi, @MohammedZuhairAhmed. |
Hello @jakobhoeg , Any updates on what changes that need to be done? |
Hello @jakobhoeg , Could you tell me the changes that needs to be done after reviewing once |
Hey, @MohammedZuhairAhmed. |
FIX : Added Prettier Formatting