Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desing #20

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Desing #20

wants to merge 4 commits into from

Conversation

markwoodhouse
Copy link
Collaborator

Tidy-up of desingularization formulae, which are now selectable in the Solver block in input files, similarly to other closures.

@jakelangham
Copy link
Owner

I'll review the desingularisation stuff properly (looks good at first glance) soon. One thing I notice is that this adds various flume topographies. We'll need to document these before merging into master. I was thinking of adding some similar additional geometries relevant for simple hydraulics simulations (const slope channels with different cross-sections). So perhaps we could carve out the topographic stuff from this update and work on that update separately on a different branch?

@markwoodhouse
Copy link
Collaborator Author

Sounds good -- I'd thought we hadn't documented all the topography options yet, so included these, but you are right that we should not add undocumented things...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants