Fix watch task's default exclude patterns to avoid "RegExp too big" error... #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
base FileList already ignores these files by default see: https://github.com/mde/filelist/blob/v0.0.4/index.js#L64
prevents 'RegExp too big' error when running in a project with lots of installed modules / module files
|
Very nice. This is awesome. |
mde
added a commit
that referenced
this pull request
Dec 2, 2015
Fix watch task's default exclude patterns to avoid "RegExp too big" error...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background: #304
all tests pass! buuut, i didn't see any for the watch task specifically. so, not a super-high level of confidence but this did fix the "RegExp too big" for me running locally via
npm linki'll think a bit more about how we might test things here. otherwise, this seem legit?