Skip to content

Commit

Permalink
Fixes #92, skip verifying SaveDataOwnerIdList against ACID as this is…
Browse files Browse the repository at this point in the history
… never populated.
  • Loading branch information
jakcron committed Dec 31, 2023
1 parent b4a86fc commit c7fe8bc
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/MetaProcess.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,9 @@ void nstool::MetaProcess::validateAciFromAcid(const pie::hac::AccessControlInfo&
}
}

// See https://github.com/jakcron/nstool/issues/92
// Nintendo doesn't populate SaveDataOwnerIdList in ACID, so this field cannot be verified
#if 0
for (size_t i = 0; i < aci.getFileSystemAccessControl().getSaveDataOwnerIdList().size(); i++)
{
bool rightFound = false;
Expand All @@ -172,6 +175,7 @@ void nstool::MetaProcess::validateAciFromAcid(const pie::hac::AccessControlInfo&
fmt::print("[WARNING] ACI/FAC SaveDataOwnerId: FAIL (0x{:016x} ({:d}) not permitted)\n", aci.getFileSystemAccessControl().getSaveDataOwnerIdList()[i].id, (uint32_t)aci.getFileSystemAccessControl().getSaveDataOwnerIdList()[i].access_type);
}
}
#endif

// check SAC
for (size_t i = 0; i < aci.getServiceAccessControl().getServiceList().size(); i++)
Expand Down

0 comments on commit c7fe8bc

Please sign in to comment.