fast-track: Add a TCK test to verify that the default ExceptionMapper can be overridden. #1235
Conversation
...tck/src/main/java/ee/jakarta/tck/ws/rs/ee/resource/webappexception/mapper/JAXRSClientIT.java
Outdated
Show resolved
Hide resolved
| import ee.jakarta.tck.ws.rs.common.JAXRSCommonClient; | ||
| import ee.jakarta.tck.ws.rs.lib.util.TestUtil; | ||
| import jakarta.ws.rs.core.Response.Status; |
There was a problem hiding this comment.
Change
Copyright (c) 2012, 2020, 2021
to
Copyright (c) 2012, 2024
There was a problem hiding this comment.
No, I was incorrect. The practices for Eclipse projects are different. https://www.eclipse.org/projects/handbook/#ip-copyright-headers
So
Copyright (c) 2012, 2020, 2021
should really be changed to
Copyright (c) 2012
There was a problem hiding this comment.
Strange, the document used to allow for a single year, or two years (creation, last modification), and in that manner the maven copyright plugin checks two year-values in the copyright header. I am not a lawyer, but I saw somewhere that a copyright wears off after some ten years, unless updated with a new code (and year).
There was a problem hiding this comment.
From the same document, FAQ section:
Do we need to specify a range of years in the copyright statement?
No. In the past, legal advice was that the year of the initial creation of the content and the year of the last change should be reflected in the copyright header. This is no longer the case. Specify the year that the content was initially created in the copyright statement.
jim-krueger
changed the title
|
@WhiteCat22 Could you address the comments pls? |
|
I have some failures locally in the other related tests. So I don't think I can re-use this existing application for this test. |
WhiteCat22
force-pushed
the
override_default_exception_mapper_tck
branch
5 times, most recently
from
fda8daa
to
6aee4c2
Compare
|
I broke out the test into a new test and application to avoid breaking existing tests. |
WhiteCat22
force-pushed
the
override_default_exception_mapper_tck
branch
2 times, most recently
from
c0bf9e6
to
498aa83
Compare
|
@alwin-joseph Could you verify the new version? |
...ee/jakarta/tck/ws/rs/ee/resource/webappexception/defaultmapper/DefaultExceptionMapperIT.java
Outdated
Show resolved
Hide resolved
...ee/jakarta/tck/ws/rs/ee/resource/webappexception/defaultmapper/DefaultExceptionMapperIT.java
Outdated
Show resolved
Hide resolved
New test passes with Glassfish8. |
…ridden. Signed-off-by: Adam Anderson <atanderson9383@gmail.com>
WhiteCat22
force-pushed
the
override_default_exception_mapper_tck
branch
from
498aa83
to
5d825a4
Compare
|
Addressed James' comments. Also, I tested this against OpenLiberty and it passes. |
|
@alwin-joseph Thank you! |
There was a problem hiding this comment.
Looks good, thank you @WhiteCat22. Passes on WildFly as well.
The
nomappertests seem to test the defaultExceptionMapper, however, we could use a test to verify that the defaultExceptionMappercan be overridden.This test overrides the default
ExceptionMapperto return status HTTP 512 instead of HTTP 500 and the test client verifies that status HTTP 512 is returned.