fast track: Port missed fixes that were in release-4.0 #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James R. Perkins <jperkins@redhat.com>
Signed-off-by: James R. Perkins <jperkins@redhat.com>
…rsion. Use version properties for all plugins. Signed-off-by: James R. Perkins <jperkins@redhat.com>
jamezp
commented
Mar 1, 2024
| @@ -119,14 +119,6 @@ | |||
| </plugin> | |||
| <plugin> | |||
| <artifactId>maven-source-plugin</artifactId> | |||
| <executions> | |||
There was a problem hiding this comment.
This was required due to https://issues.apache.org/jira/browse/MSOURCES-121. The jar-no-fork goal is defined as an execution in the root POM.
jim-krueger
approved these changes
Mar 1, 2024
jansupol
approved these changes
Mar 4, 2024
spericas
approved these changes
Mar 5, 2024
arjantijms
approved these changes
Mar 5, 2024
jim-krueger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found these commits I missed that were in release-4.0 and not in main or release-3.2.
GItHub Links
The first commit is to fix a bad port which reverted some changes from #1177
Asciidoctor Dependency Updates
These are from #1170
Maven Plugin Dependency Updates
This includes a JUnit and mockito upgrades as well. This is a port of #1169