Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module info and update pom #1903

Merged
merged 1 commit into from Mar 12, 2024
Merged

Add module info and update pom #1903

merged 1 commit into from Mar 12, 2024
+77 −14

Conversation

arjantijms
Copy link
Contributor

@arjantijms arjantijms commented Mar 5, 2024 •
edited

Fixes #1815

@arjantijms
Add module info and update pom
e2e2c2f 
Signed-off-by: Arjan Tijms <arjan.tijms@omnifish.ee>
@arjantijms arjantijms added this to the 4.1 milestone Mar 5, 2024
dmatej
dmatej approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@dmatej dmatej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those transitive required? Especially desktop seems suspicious to me...

@arjantijms
Copy link
Contributor Author

Especially desktop seems suspicious to me...

Unfortunately, yes :(

The API internally has references to java.beans.Beans. It's not pretty, but anything less and the project won't compile (if you want, you can try if you can find something smaller, but I couldn't)

@arjantijms arjantijms mentioned this pull request Mar 6, 2024
Closed
@arjantijms arjantijms linked an issue Mar 6, 2024 that may be closed by this pull request
Missing module-info.java leading to nasty warnings from compiler plugin #1815
Closed
lprimak
lprimak approved these changes Mar 12, 2024
View reviewed changes
Copy link

@lprimak lprimak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiles, deploys and runs. No warnings

@arjantijms
Copy link
Contributor Author

Thanks @lprimak !

@arjantijms arjantijms merged commit 083d183 into jakartaee:4.1 Mar 12, 2024
1 check passed
@arjantijms arjantijms deleted the module-info branch March 12, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmatej dmatej dmatej approved these changes

@lprimak lprimak lprimak approved these changes

@BalusC BalusC Awaiting requested review from BalusC

@jasondlee jasondlee Awaiting requested review from jasondlee

@tandraschko tandraschko Awaiting requested review from tandraschko

@mnriem mnriem Awaiting requested review from mnriem

@pnicolucci pnicolucci Awaiting requested review from pnicolucci

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Missing module-info.java leading to nasty warnings from compiler plugin
3 participants
@arjantijms @dmatej @lprimak