AnnotationFullTests adds resource definitions with qualifiers on a CDI bean #491
Conversation
…DI bean Fixes jakartaee#489 Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
This is because Servlet 3.0 explicitly forbids using other CDI qualifiers on servlets. Although it seems that this restriction was removed, some servers still abide it. Fixes jakartaee#489 Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
There was a problem hiding this comment.
I decided to use
@Dependentscope because Servlet spec version 3.0 explicitly forbids other CDI scopes for servlets. Some servers still abide this even though it seems this restriction was removed in newer Servlet spec versions. Concurrency TCK should be contain any assertions for other specs, so I use widely accepted@Dependent.
We shouldn't be concerned with something from Servlet 3.0 that no longer applies in EE 11, but @Dependent is fine as well. Approving.
You can go ahead and cancel the similar pull for this same fix that I created earlier after Arjan had assigned the issue to me, and which I misinterpreted as being asked to put the change in. It makes more sense to have you make the TCK update because you can confirm that you are passing the TCK with it.
The servlet
AnnotationServletturned into anDependentCDI bean so that it's scanned by a CDI extension, which can then read the definitions from the annotations.I decided to use
@Dependentscope because Servlet spec version 3.0 explicitly forbids other CDI scopes for servlets. Some servers still abide this even though it seems this restriction was removed in newer Servlet spec versions. Concurrency TCK should not contain any assertions for other specs, so I use widely accepted@Dependent.Fixes #489