Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move EE dependency version properties to parent pom #787

Merged
merged 3 commits into from Mar 1, 2024
Merged

Move EE dependency version properties to parent pom #787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66c2145
Restore the issue templates
starksm64 Mar 1, 2024
980b619
Merge branch '4.1' of https://github.com/jakartaredhat/cdi into 4.1
starksm64 Mar 1, 2024
1a484db
- Move EE dependency version properties to parent pom, fixes #786
starksm64 Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
View file
Open in desktop
@@ -1,3 +1,6 @@
<!--
SPDX-License-Identifier: Apache-2.0
-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there's a YAML front matter below. This comment will make it not work. I'd suggest moving the comment into the front matter, using YAML comments:

---
# SPDX-License-Identifier: Apache-2.0

name: Bug report
about: Create a report to help us improve
title: ''
labels: ''
assignees: ''
---

...

That's what I did with the Jekyll templates in the docs directory.

---
name: Bug report
about: Create a report to help us improve
Expand Down
3 changes: 3 additions & 0 deletions .github/ISSUE_TEMPLATE/compatibility-certification-request.md
View file
Open in desktop
@@ -1,3 +1,6 @@
<!--
SPDX-License-Identifier: Apache-2.0
-->
---
name: Compatibility certification request
about: Request certification of a compatibile implementation of Jakarta EE
Expand Down
3 changes: 3 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
View file
Open in desktop
@@ -1,3 +1,6 @@
<!--
SPDX-License-Identifier: Apache-2.0
-->
---
name: Feature request
about: Suggest an idea for this project
Expand Down
8 changes: 2 additions & 6 deletions api/pom.xml
View file
Open in desktop
Expand Up @@ -18,7 +18,7 @@
<parent>
<groupId>jakarta.enterprise</groupId>
<artifactId>jakarta.enterprise.cdi-parent</artifactId>
<version>4.1.0</version>
<version>4.1.0-SNAPSHOT</version>
</parent>

<artifactId>jakarta.enterprise.cdi-api</artifactId>
Expand All @@ -38,7 +38,7 @@

<issueManagement>
<system>Jakarta CDI Issues</system>
<url>https://github.com/eclipse-ee4j/cdi/issues</url>
<url>https://github.com/jakarta/cdi/issues</url>
</issueManagement>

<inceptionYear>2008</inceptionYear>
Expand Down Expand Up @@ -121,10 +121,6 @@


<properties>
<annotation.api.version>3.0.0</annotation.api.version>
<atinject.api.version>2.0.1</atinject.api.version>
<uel.api.version>6.0.0</uel.api.version>
<interceptor.api.version>2.2.0</interceptor.api.version>
<maven.build.timestamp.format>MMMM dd, yyyy</maven.build.timestamp.format>
</properties>

Expand Down
6 changes: 1 addition & 5 deletions el/pom.xml
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@
<parent>
<groupId>jakarta.enterprise</groupId>
<artifactId>jakarta.enterprise.cdi-parent</artifactId>
<version>4.1.0</version>
<version>4.1.0-SNAPSHOT</version>
</parent>

<artifactId>jakarta.enterprise.cdi-el-api</artifactId>
Expand All @@ -30,10 +30,6 @@
</license>
</licenses>

<properties>
<uel.api.version>6.0.0-M1</uel.api.version>
</properties>

<dependencyManagement>
<dependencies>
<dependency>
Expand Down
2 changes: 1 addition & 1 deletion ide-config/pom.xml
View file
Open in desktop
Expand Up @@ -14,7 +14,7 @@
<parent>
<groupId>jakarta.enterprise</groupId>
<artifactId>jakarta.enterprise.cdi-parent</artifactId>
<version>4.1.0</version>
<version>4.1.0-SNAPSHOT</version>
</parent>

<artifactId>cdi-ide-config</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion lang-model/pom.xml
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@
<parent>
<groupId>jakarta.enterprise</groupId>
<artifactId>jakarta.enterprise.cdi-parent</artifactId>
<version>4.1.0</version>
<version>4.1.0-SNAPSHOT</version>
</parent>

<artifactId>jakarta.enterprise.lang-model</artifactId>
Expand Down
8 changes: 7 additions & 1 deletion pom.xml
View file
Open in desktop
Expand Up @@ -19,7 +19,7 @@
<groupId>jakarta.enterprise</groupId>
<artifactId>jakarta.enterprise.cdi-parent</artifactId>
<packaging>pom</packaging>
<version>4.1.0</version>
<version>4.1.0-SNAPSHOT</version>

<description>Parent module for CDI Specification</description>

Expand Down Expand Up @@ -117,6 +117,12 @@
</build>

<properties>
<!-- Definitions for the Jakarta EE API dependency versions -->
<annotation.api.version>3.0.0</annotation.api.version>
<atinject.api.version>2.0.1</atinject.api.version>
<uel.api.version>6.0.0</uel.api.version>
<interceptor.api.version>2.2.0</interceptor.api.version>

<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<maven.compiler.release>11</maven.compiler.release>
Expand Down
2 changes: 1 addition & 1 deletion spec/pom.xml
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@
<parent>
<groupId>jakarta.enterprise</groupId>
<artifactId>jakarta.enterprise.cdi-parent</artifactId>
<version>4.1.0</version>
<version>4.1.0-SNAPSHOT</version>
</parent>

<artifactId>jakarta.enterprise.cdi-spec-doc</artifactId>
Expand Down