Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Various Wayland Fixes #173

Open
wants to merge 2 commits into
base: fixes/wayland
Choose a base branch
from

Conversation

mayanksuman
Copy link
Contributor

  1. Implements xdg-desktop-portal based screenshot capture
  2. No QMenu without parent widget: as this causes issues with wayland as per https://community.kde.org/Guidelines_and_HOWTOs/Wayland_Porting_Notes

@jahnf
Copy link
Owner

jahnf commented Nov 8, 2021

Thanks for the PR.
Did you test, the context menu on Xorg?
I remember vaguely, that the menu behaved weird of it had the application as a parent.

@jahnf
Copy link
Owner

jahnf commented Nov 8, 2021

Essentially your change to

new QMenu(qobject_cast<QWidget*>(m_trayIcon.get()))

will be the same as new QMenu(nullptr)

QSystemtrayIcon is not a QWidget, the cast will return a nullptr.

@flipreverse
Copy link

flipreverse commented Nov 1, 2023

@mayanksuman Thx for your PR. I gave it a try. :) It works -- except for the first seconds. At the beginning, I see several error messages. They state no screenshot could be taken. After a few seconds, it works.

@jahnf Will this PR be merged?

@jahnf
Copy link
Owner

jahnf commented Dec 21, 2023

Yes eventually, it will. sorry the project is moving slow currently - The screenshot issue is the least of the problems that occur with Wayland + Qt and the Projecteur that needs to be a window above others - which just doesn't work as with X anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants