Add cache_clear operation
#200
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaemk
reviewed
Apr 7, 2024
src/stores/redis.rs
Outdated
Comment on lines
347
to
348
| // https://redis.io/commands/flushdb/ | ||
| let _: () = redis::cmd("FLUSHDB").query(&mut *conn)?; |
There was a problem hiding this comment.
Wouldn't this delete someone's entire redis db? I think a scan + delete would need to be done instead, using the self.namespace + self.prefix in the scan
There was a problem hiding this comment.
Oh I just assumed the Redis DB was already unique per cache. I can fix this.
There was a problem hiding this comment.
I took a shot at it but needing two connections seems weird. scan_match needs &mut self, though, so I can't do anything with the deserialized values without opening another connection or collecting them all into memory first.
https://docs.rs/redis/latest/redis/trait.Commands.html#method.scan_match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #197.