Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new grpc storage configuration to align with OTEL #5331

Merged
merged 30 commits into from May 20, 2024

Conversation

akagami-harsh
Copy link
Member

@akagami-harsh akagami-harsh commented Apr 5, 2024

Which problem is this PR solving?

Description of the changes

  • added more grpc storage client configuration to align with otel
   configgrpc.ClientConfig        `mapstructure:",squash"`
   exporterhelper.TimeoutSettings `mapstructure:",squash"`

These are not all the configs, but i'll add more based on feedback on this initial approach.

How was this change tested?

  • not tested yet

Checklist

akagami-harsh and others added 2 commits April 6, 2024 00:08
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 95.50%. Comparing base (2eee293) to head (f3c2ccf).

Files Patch % Lines
plugin/storage/grpc/config/config.go 88.88% 2 Missing and 1 partial ⚠️
plugin/storage/grpc/factory.go 96.15% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5331      +/-   ##
==========================================
+ Coverage   95.48%   95.50%   +0.02%     
==========================================
  Files         331      331              
  Lines       16121    16139      +18     
==========================================
+ Hits        15393    15414      +21     
+ Misses        555      552       -3     
  Partials      173      173              
Flag Coverage Δ
badger_v1 8.05% <0.00%> (-0.02%) ⬇️
badger_v2 1.93% <0.00%> (-0.01%) ⬇️
cassandra-3.x-v1 16.43% <0.00%> (-0.04%) ⬇️
cassandra-3.x-v2 1.85% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v1 16.43% <0.00%> (-0.04%) ⬇️
cassandra-4.x-v2 1.85% <0.00%> (-0.01%) ⬇️
elasticsearch-7.x 1.76% <0.00%> (?)
elasticsearch-8.x 1.78% <0.00%> (?)
grpc_v1 9.53% <84.93%> (+0.28%) ⬆️
grpc_v2 7.58% <0.00%> (-0.02%) ⬇️
kafka 9.78% <0.00%> (-0.03%) ⬇️
opensearch-1.x 1.78% <0.00%> (?)
opensearch-2.x 1.78% <0.00%> (?)
unittests 93.90% <67.56%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

go.mod Outdated Show resolved Hide resolved
plugin/storage/grpc/config/config.go Outdated Show resolved Hide resolved
akagami-harsh and others added 7 commits April 7, 2024 18:35
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
@akagami-harsh akagami-harsh marked this pull request as ready for review April 8, 2024 14:24
@akagami-harsh akagami-harsh requested a review from a team as a code owner April 8, 2024 14:24
@akagami-harsh akagami-harsh marked this pull request as draft May 10, 2024 23:17
akagami-harsh and others added 2 commits May 12, 2024 13:32
Signed-off-by: Harshvir Potpose <122517264+akagami-harsh@users.noreply.github.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
@akagami-harsh akagami-harsh marked this pull request as ready for review May 12, 2024 13:24
cmd/remote-storage/app/server.go Outdated Show resolved Hide resolved
plugin/storage/grpc/config/config.go Outdated Show resolved Hide resolved
plugin/storage/grpc/factory.go Show resolved Hide resolved
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
@yurishkuro yurishkuro added v2 changelog:exprimental Change to an experimental part of the code labels May 16, 2024
@yurishkuro yurishkuro changed the title add grpc storage client configuration to align with OTEL Create new grpc storage configuration to align with OTEL May 16, 2024
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like you're picking some go.mod changes because your branch is not up to date. Please rebase on main

plugin/storage/grpc/config/config.go Outdated Show resolved Hide resolved
plugin/storage/grpc/config/config.go Outdated Show resolved Hide resolved
plugin/storage/grpc/config/config.go Outdated Show resolved Hide resolved
plugin/storage/grpc/config/config.go Show resolved Hide resolved
plugin/storage/grpc/factory.go Outdated Show resolved Hide resolved
plugin/storage/grpc/config/config.go Outdated Show resolved Hide resolved
plugin/storage/grpc/options.go Outdated Show resolved Hide resolved
akagami-harsh and others added 7 commits May 16, 2024 20:50
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I refactored & cleaned-up a bit more to make the code simpler.

pkg/config/tlscfg/options.go Outdated Show resolved Hide resolved
plugin/storage/grpc/config/config.go Show resolved Hide resolved
plugin/storage/grpc/factory.go Outdated Show resolved Hide resolved
Signed-off-by: Yuri Shkuro <github@ysh.us>
akagami-harsh and others added 3 commits May 20, 2024 23:44
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
@yurishkuro yurishkuro merged commit c840816 into jaegertracing:main May 20, 2024
37 of 38 checks passed
@akagami-harsh akagami-harsh deleted the grpc-config branch May 20, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:exprimental Change to an experimental part of the code v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants