add start and end parameters #4352
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pavolloffay @yurishkuro could u help with this PR? |
yurishkuro
reviewed
Apr 5, 2023
Signed-off-by: alburthoffman <alburthoffman@gmail.com>
alburthoffman
force-pushed
the
time_parameters
branch
from
15d3c5e
to
7cf9821
Compare
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
reviewed
Jun 3, 2023
| @@ -61,6 +61,13 @@ type Reader interface { | |||
| FindTraceIDs(ctx context.Context, query *TraceQueryParameters) ([]model.TraceID, error) | |||
| } | |||
|
|
|||
| // TraceIDQueryParameters contains parameters of a trace id query. | |||
| type TraceIDQueryParameters struct { | |||
There was a problem hiding this comment.
this is rather unwieldy name, can we shorted to TraceIDQuery ?
| @@ -36,7 +36,7 @@ type Reader interface { | |||
| // GetTrace retrieves the trace with a given id. | |||
| // | |||
| // If no spans are stored for this trace, it returns ErrTraceNotFound. | |||
| GetTrace(ctx context.Context, traceID model.TraceID) (*model.Trace, error) | |||
| GetTrace(ctx context.Context, query *TraceIDQueryParameters) (*model.Trace, error) | |||
There was a problem hiding this comment.
Suggested change
| GetTrace(ctx context.Context, query *TraceIDQueryParameters) (*model.Trace, error) | |
| GetTrace(ctx context.Context, query TraceIDQueryParameters) (*model.Trace, error) |
The query is required, no reason to pass via pointer
yurishkuro
reviewed
Jun 3, 2023
|
The Proto file changes that include time stamps have been merged separately. This needs to be rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves 4150
Short description of the changes
allow optional time parameters when querying trace by id