Speed up Critical path calculation #1975
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Gaponov <gaponovmaxev@gmail.com>
yurishkuro
reviewed
Nov 14, 2023
| ): criticalPathSection[] => { | ||
| const currentSpan: Span = spanMap.get(spanId)!; | ||
| let criticalPathBoundary = currentSpan.startTime + currentSpan.duration; |
There was a problem hiding this comment.
confusing name, boundary can be either top or bottom
| spanId: currentSpan.spanID, | ||
| section_start: childEndTime, | ||
| section_end: criticalPathBoundary, | ||
| }; |
There was a problem hiding this comment.
I don't follow. criticalPathBoundary is initially end-of-parent. This says if the child ends before than, then the difference between child.end and parent.end is the critical path contributed by that span?
| reference => reference.refType === 'CHILD_OF' | ||
| )[0].spanID; | ||
| computeCriticalPath(spanMap, parentSpanId, criticalPath, currentSpan.startTime); | ||
| for (let i = 0; i < currentSpan.childSpanIds.length; i++) { |
There was a problem hiding this comment.
is there an assumption on the order of this array?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test