Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Speed up Critical path calculation #1943

Open
maxgaponov opened this issue Nov 3, 2023 · 0 comments
Open

[Feature]: Speed up Critical path calculation #1943

maxgaponov opened this issue Nov 3, 2023 · 0 comments

Comments

@maxgaponov
Copy link
Contributor

Requirement

I would like to view big traces in Jaeger UI.

Problem

Critical path calculation works slowly on large traces (especially if I press "Collapse all").

Proposal

No response

Open questions

No response

yurishkuro added a commit that referenced this issue Nov 13, 2023
## Which problem is this PR solving?
- Part of #1943 

## Description of the changes
- mergeChildrenCriticalPath shortcuts for an empty critical path

## How was this change tested?
- Existing tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: Maksim Gaponov <gaponovmaxev@gmail.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant