[jaeger-operator]upgrade to using helm3 crd procedure since crd-install hook is no lon… #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger supported fixes jaegertracing#170 chart.Values.crd.install is no longer support since crd MUST be install refer: https://helm.sh/docs/topics/charts/#custom-resource-definitions-crds Signed-off-by: vincentcui <vincentcui@tencent.com>
kd7lxl
reviewed
Jan 25, 2021
| @@ -2,9 +2,6 @@ apiVersion: apiextensions.k8s.io/v1beta1 | |||
| kind: CustomResourceDefinition | |||
| metadata: | |||
| name: jaegers.jaegertracing.io | |||
| annotations: | |||
| "helm.sh/hook": crd-install | |||
Comment on lines
-1
to
-6
| {{- if .Values.crd.install }} | ||
| {{- range $path, $bytes := .Files.Glob "crds/*.yaml" }} | ||
| {{ $.Files.Get $path }} | ||
| --- | ||
| {{- end }} | ||
| {{- end }} |
There was a problem hiding this comment.
This is still useful for systems that use helm template to generate manifests but don't use helm install to deploy. Particularly, it's useful when upgrading CRDs, since helm upgrade doesn't provide support for upgrading CRDs.
I would leave it.
|
@vincenthcui any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
upgrade to using helm3 crd procedure since crd-install hook is no longer supported
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format,will close that issue when PR gets merged)
Checklist
[jaeger]or[jaeger-operator])