Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jaeger-operator] Helm skipping crd-install hook #170

Open
csp197 opened this issue Nov 3, 2020 · 3 comments · May be fixed by #173
Open

[jaeger-operator] Helm skipping crd-install hook #170

csp197 opened this issue Nov 3, 2020 · 3 comments · May be fixed by #173

Comments

@csp197
Copy link
Contributor

csp197 commented Nov 3, 2020

Hello!

I've been trying to install the Jaeger Operator into a namespace of an EKS cluster using the prescribed helm charts, but my build pipeline starts to fail upon setting the following configuration in the values.yaml file:

jaeger:
  # Specifies whether Jaeger instance should be created
  create: true

Below are the appropriate logs re: this issue:

Release "jaeger-operator" does not exist. Installing it now.
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
Error: unable to build kubernetes objects from release manifest: unable to recognize "": no matches for kind "Jaeger" in version "jaegertracing.io/v1"
ERROR: Job failed: command terminated with exit code 1
vincenthcui added a commit to vincenthcui/helm-charts that referenced this issue Nov 26, 2020
@vincenthcui
upgrade to using helm3 crd procedure since crd-install hook is no lon…
0a52318 
…ger supported

fixes jaegertracing#170

chart.Values.crd.install is no longer support since crd MUST be install
refer: https://helm.sh/docs/topics/charts/#custom-resource-definitions-crds
@vincenthcui vincenthcui linked a pull request Nov 26, 2020 that will close this issue
Open
4 tasks
vincenthcui added a commit to vincenthcui/helm-charts that referenced this issue Nov 26, 2020
@vincenthcui
upgrade to using helm3 crd procedure since crd-install hook is no lon…
cab19b9 
…ger supported

fixes jaegertracing#170

chart.Values.crd.install is no longer support since crd MUST be install
refer: https://helm.sh/docs/topics/charts/#custom-resource-definitions-crds

Signed-off-by: vincentcui <vincentcui@tencent.com>
vincenthcui added a commit to vincenthcui/helm-charts that referenced this issue Nov 26, 2020
@vincenthcui
upgrade to using helm3 crd procedure since crd-install hook is no lon…
013fbb7 
…ger supported

fixes jaegertracing#170

chart.Values.crd.install is no longer support since crd MUST be install
refer: https://helm.sh/docs/topics/charts/#custom-resource-definitions-crds

Signed-off-by: vincentcui <vincentcui@tencent.com>
@vincenthcui
Copy link

@csp197 Hi, I create a pull request trying to solve this problem, plz pull the source code and test in your local cluster.

@csp197
Copy link
Contributor Author

csp197 commented Dec 20, 2020

Hi @vincenthcui
I resolved this issue by installing the Jaeger Operator using the helm chart first, and then later creating the Jaeger Operator after installation.

I see that you have an open PR regarding this issue, so I'll leave the issue open until it gets merged. 👍

@m1o1
Copy link

m1o1 commented Mar 28, 2022

I ran into this when I added the jaeger-operator chart as a dependency to my chart. It skipped installing crds, I assume because I was running "helm upgrade --install" and my chart was already installed, so it did an upgrade. When I uninstalled my chart and reran the command, it installed the CRDs properly.

I know this might just be a helm thing though (since helm doesn't let you add CRDs during upgrades for some reason, which is effectively what I did when I added this as a dependency). Just pointing it out in case someone runs into the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@vincenthcui @csp197 @m1o1