Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in OpenTelemetry #700

Merged
merged 2 commits into from May 11, 2024
Merged

Fix typo in OpenTelemetry #700

merged 2 commits into from May 11, 2024

Conversation

MA3CIN
Copy link
Contributor

@MA3CIN MA3CIN commented May 9, 2024

Which problem is this PR solving?

a typo in troubleshooting.MD

Surprisingly, the spellcheck didn't pick this one up, probably due to the Markdown hashtags being interpreted as a comment.
image

Checklist

MA3CIN and others added 2 commits May 9, 2024 10:16
Signed-off-by: Marcin Ziółkowski <62351083+MA3CIN@users.noreply.github.com>
Signed-off-by: MA3CIN <marcin.zet@onet.pl>
Copy link

netlify bot commented May 9, 2024

Deploy Preview for romantic-neumann-1959d7 ready!

Name Link
🔨 Latest commit 7c1367e
🔍 Latest deploy log https://app.netlify.com/sites/romantic-neumann-1959d7/deploys/663c88757503ff0008458181
😎 Deploy Preview https://deploy-preview-700--romantic-neumann-1959d7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall there were many misspelled words added to the dictionary file, can you check?

@MA3CIN
Copy link
Contributor Author

MA3CIN commented May 9, 2024

@yurishkuro Yes, you are right. Some of these are an easy fix, but the rest... I'm not sure if these are even words in English...?
boths? bohara? afzal? ansh? Most of these are names. I guess if a word is neither a name nor an established term in Software, i'll purge it.

@yurishkuro
Copy link
Member

boths? bohara? afzal? ansh?

boths sounds like a typo, the others are people's names (interns from the mentorship program / page). I don't know what a good way to handle this, we cannot just remove them from the dictionary, the linter will start failing.

@MA3CIN
Copy link
Contributor Author

MA3CIN commented May 10, 2024

@yurishkuro Alright, then i propose the following:
Accept and close this PR, because the changes here are indifferent to the linter and spellchecker
I'll open a separate PR fixing the Dictionary file, on which we can review and discuss the proposed changes

@yurishkuro
Copy link
Member

Sure, but to complete this PR I want to make sure this misspelled work is not in the dictionary.

@MA3CIN
Copy link
Contributor Author

MA3CIN commented May 11, 2024

@yurishkuro I see - all three (opentelemetry, opentracing, openzipkin) are spelled correctly in the dictionary. I checked that initially, but didn't comment that I did. The spellechecker must have ignored Markdown hashtags, and interpreted them as a comment.

@yurishkuro yurishkuro changed the title Patch 1 Fix typo in OpenTelemetry May 11, 2024
@yurishkuro yurishkuro merged commit 9da1045 into jaegertracing:main May 11, 2024
10 checks passed
@yurishkuro
Copy link
Member

#701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants