Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a small typo #694

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

virtualandy
Copy link

@virtualandy virtualandy commented Apr 19, 2024

Which problem is this PR solving?

Eek, I didn't create an issue since this was such a small change. I can definitely do that if needed!

Description of the changes

Just fixing a typo.

How was this change tested?

I didn't run locally 😭 since just a typo fix.

Checklist

* s/distirbuted/distributed - happened to notice as I was browsing the docs

Signed-off-by: Andy <virtualandy@gmail.com>
Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for romantic-neumann-1959d7 ready!

Name Link
🔨 Latest commit fd1f651
🔍 Latest deploy log https://app.netlify.com/sites/romantic-neumann-1959d7/deploys/6623373ad955160008a8ae0f
😎 Deploy Preview https://deploy-preview-694--romantic-neumann-1959d7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@virtualandy
Copy link
Author

The typo is in versions 1.56 and earlier - if I got this wrong by editing next-release let me know and I'm happy to fix it up!

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching. Turns out we have an invalid word in the allowed dictionary, and not the only one wrong. We should fix if there first and the linter will flag all occurances.

@virtualandy
Copy link
Author

@yurishkuro oh, neat, didn't realize that was there (apologies, I should've read all the docs/setup flow first :) ).
I made an update to that word to see how it affects the build/tests. I'll scan it for other typos too.

* Thanks to @yurishkuro for pointing out, let's see how this shows up in the build

Signed-off-by: Andy <virtualandy@gmail.com>
@@ -23,7 +23,7 @@ datacenter
datasource
developercertificate
dilligence
distirbuted
distributed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe we need this in the words list. btw dilligence is also misspelled (only needs one l)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants