New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing a small typo #694
base: main
Are you sure you want to change the base?
Fixing a small typo #694
Conversation
* s/distirbuted/distributed - happened to notice as I was browsing the docs Signed-off-by: Andy <virtualandy@gmail.com>
✅ Deploy Preview for romantic-neumann-1959d7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The typo is in versions 1.56 and earlier - if I got this wrong by editing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for catching. Turns out we have an invalid word in the allowed dictionary, and not the only one wrong. We should fix if there first and the linter will flag all occurances.
distirbuted |
@yurishkuro oh, neat, didn't realize that was there (apologies, I should've read all the docs/setup flow first :) ). |
* Thanks to @yurishkuro for pointing out, let's see how this shows up in the build Signed-off-by: Andy <virtualandy@gmail.com>
@@ -23,7 +23,7 @@ datacenter | |||
datasource | |||
developercertificate | |||
dilligence | |||
distirbuted | |||
distributed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe we need this in the words list. btw dilligence is also misspelled (only needs one l)
Which problem is this PR solving?
Eek, I didn't create an issue since this was such a small change. I can definitely do that if needed!
Description of the changes
Just fixing a typo.
How was this change tested?
I didn't run locally 😭 since just a typo fix.
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test