New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI workflow to validate generated Docker image #33
base: main
Are you sure you want to change the base?
Add CI workflow to validate generated Docker image #33
Conversation
ran successfully on my fork |
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
7758dd6
to
c7117ca
Compare
on: | ||
push: | ||
branches: | ||
- master | ||
pull_request: | ||
branches: | ||
- master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the trigger conditions be consistent with existing build tasks?
on:
push:
tags:
- '**'
branches:
- master
pull_request:
paths:
- .github/workflows/jaeger-dockerimage.yml
- Dockerfile
- protoc-wrapper
Alternatively, checkout
and build proto
can be integrated directly into the original CI so that we can directly confirm a successful build before the image is released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added triggers same as the jaeger-dockerimage.yml
in this workflow
Signed-off-by: Harshvir Potpose <122517264+akagami-harsh@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx
Summary
Changes
jaeger
andjaeger-idl