fix bug in Dockerfile for python #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panlichen
changed the title
yurishkuro
requested changes
Nov 12, 2020
Dockerfile
Outdated
| make -j4 check && \ | ||
| make -j4 install && \ | ||
| make -j4 install DESTDIR=/out && \ | ||
| make -j21 && \ |
There was a problem hiding this comment.
why does this need to change?
|
I work on a 20 core platform. Maybe it is better to automize this
configuration, but I do not know how to do it in Dockerfile.
Yuri Shkuro <notifications@github.com> 于 2020年11月13日周五 01:53写道：
… ***@***.**** requested changes on this pull request.
Please undo changes to unrelated files
------------------------------
In Dockerfile
<#22 (comment)>
:
> @@ -23,12 +23,12 @@ RUN apk add --no-cache automake && \
cd /protobuf && \
./autogen.sh && \
./configure --prefix=/usr --enable-static=no && \
- make -j4 && \
- make -j4 check && \
- make -j4 install && \
- make -j4 install DESTDIR=/out && \
+ make -j21 && \
why does this need to change?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#22 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADIFMSRUK4KYDUQQ7RC4OGTSPQOIDANCNFSM4TTITPDQ>
.
|
The build runs on Travis-ci |
|
In the new commit, I rollback the -j change. I am not familiar with Travis-ci, does the default setting for it use a four-core platform? |
|
Will this tiny fix be merged? |
|
Why is it even a bug? It seems consistent with the naming of all other plugins. What is the reproducer that demonstrates that this does not work? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix typo in Dockerfile to make it work with
--grpc_python_out=option.sorry for other chaos in code.
...
Changes
Notes for Reviewers
...
Release Notes