Upgrade protoc, grpc, go, alpine and gogo versions #20
Conversation
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
patch-2
branch
from
b9b930f
to
1965d41
Compare
|
@pavolloffay @jpkrohling can you please help me with this PR, and consider to do a release? I want to update generated model file in the jaeger in the end :) |
|
We have an issue on rebasing this repo with the origin (#17). Would you be interested in working on that instead? This would be the proper solution. |
|
@jpkrohling I can help with that after, but I need this change soon if possible. |
|
As long as CI is happy, I'm also happy with this change, but @pavolloffay should also take a look, as he has also dealt with this in the past few days. |
|
The problem is the newer gogoproto+protoc generate a new |
|
Yeah, I think that's one of the issues we faced, but not the only one, IIRC. |
|
@jpkrohling @pavolloffay you may consider to use https://github.com/open-telemetry/build-tools/blob/master/protobuf/README.md, which is a bit newer (includes this change at least). And we may solve the issue in one place |
|
I am +1 on unifying the OTEL proto generation with Jaeger. Is https://github.com/open-telemetry/build-tools/blob/master/protobuf/README.md used in the OTEL collector? I could not find a reference to it there. |
|
What's the current agreement on this? Will we first rebase this to the latest version from the fork, and then push the changes downstream to OpenTelemetry's, or will this repository here be deprecated in favor of OpenTelemetry's right away? If we'll deprecate this, we should first rebase OpenTelemetry's then, IMO. |
|
It is not clear from #20 (comment) that OTEL version will work. If OTEL docker image is ready and we can successfully run in in jaeger repo, then +1 to switch. |
|
@yurishkuro we made a release of the first version. I can give a try to use it in one of the go repositories. |
No description provided.