Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI workflow to validate generated Docker image against other Jaeger repos #30

Open
yurishkuro opened this issue Nov 9, 2023 · 1 comment · May be fixed by #33
Open

Add CI workflow to validate generated Docker image against other Jaeger repos #30

yurishkuro opened this issue Nov 9, 2023 · 1 comment · May be fixed by #33
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@yurishkuro
Copy link
Member

Right now we don't have any validation that any changes to the image will not break the repos where it is consumed, namely jaeger and jaeger-idl.

Proposal: Add a CI workflow that will check out those repos as part of the CI, and run their proto build steps using the new version of the image. This may involve tweaking their Makefiles to allow overriding image version (but may already be supported, needs to be verified).
@yurishkuro yurishkuro added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 9, 2023
@yurishkuro yurishkuro mentioned this issue Nov 9, 2023
Closed
@yurishkuro yurishkuro changed the title Add CI workflow to validate generated Docker image against main Jaeger repo Add CI workflow to validate generated Docker image against other Jaeger repos Nov 9, 2023
@akagami-harsh
Copy link
Member

working on this !!

@akagami-harsh akagami-harsh linked a pull request Nov 12, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CI workflow to validate generated Docker image akagami-harsh/docker-protobuf
2 participants
@yurishkuro @akagami-harsh