Add CI workflow to validate generated Docker image #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ran successfully on my fork |
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
akagami-harsh
force-pushed
the
ci-validation-of-docker-images
branch
from
7758dd6
to
c7117ca
Compare
Wh1isper
reviewed
Nov 13, 2023
Comment on lines
2
to
8
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| pull_request: | ||
| branches: | ||
| - master |
There was a problem hiding this comment.
Should the trigger conditions be consistent with existing build tasks?
on:
push:
tags:
- '**'
branches:
- master
pull_request:
paths:
- .github/workflows/jaeger-dockerimage.yml
- Dockerfile
- protoc-wrapperAlternatively, checkout and build proto can be integrated directly into the original CI so that we can directly confirm a successful build before the image is released.
There was a problem hiding this comment.
added triggers same as the jaeger-dockerimage.yml in this workflow
Signed-off-by: Harshvir Potpose <122517264+akagami-harsh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
jaegerandjaeger-idl