My recs #1
Open
My recs #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes explicit clang version number.
ryanhaining
commented
Sep 27, 2016
| send(Http::sck, req, std::string(req).length(), 0); | ||
| char* buffer = (char *)malloc(BUFFER_SIZE); |
There was a problem hiding this comment.
if you really were to malloc, the most C++-ish thing here would've been
auto buffer = static_cast<char*>(std::malloc(BUFFER_SIZE));
ryanhaining
commented
Sep 27, 2016
| @@ -35,15 +33,12 @@ void Http::connect(std::string url) { | |||
| } | |||
|
|
|||
| std::string Http::makeRequest(const char *req) { | |||
| constexpr auto BUFFER_SIZE = 10000; | |||
| send(Http::sck, req, std::string(req).length(), 0); | |||
There was a problem hiding this comment.
std::string(req).length() should be std::strlen(req) mah b.
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good job dudes.
This is mostly academic or "modernizing" stuff. Only the change in http.cpp fixes an actual problem. Bringing down the makefile is pretty good to know too, IMO, but for anything over small projects I'd recommend learning
sconsor another system.