Skip to content
This repository has been archived by the owner on Feb 12, 2019. It is now read-only.

Add auto-buddy feature for published rosters #170

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Peter2121
Copy link

No description provided.

Copy link
Member

@smokku smokku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather see it as a separate option, not a magic number under fix-subscriptions.

Also, there is no reason to change whitespace formatting in lines you do not need to change.

@Peter2121
Copy link
Author

The problem of separate option is that this option will conflict with fix-subscriptions. That's why I used the 'magic number'. In that case we need to add something like super-option subscriptions with two possible options inside - fix-subscriptions and auto-buddy. But this approach will completely break the compatibility of config files with previous versions and it needs more modifications in the code of reading config (so more possible bugs).
I would like to get your advise on it.

@smokku
Copy link
Member

smokku commented Mar 14, 2018

There is no conflict, just a requirement.
New option <auto-budy/> needs <fix-subscriptions/> turned on to work. Just make it clear in the comment explaining the option.

@Peter2121
Copy link
Author

Peter2121 commented Mar 14, 2018

New option auto-buddy needs fix-subscriptions turned OFF to work.

If you think it's OK like this - I'll try to go this way, but I need some time to change it.

@smokku smokku force-pushed the master branch 8 times, most recently from bc546fa to 59df103 Compare April 22, 2018 10:31
@Neustradamus
Copy link

Neustradamus commented Nov 1, 2018

@smokku @Peter2121 Any news?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants