Fixing flaky tests in RedditScopeBuilderTest and KeyValueFormatterTest #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following tests are flaky because of the underlying implementation of KeyValueFormatter.format() and builder.build() methods. Calling these methods twice can return the opposite values every time for the string values it is being compared to. Instead extracting out the method call ensures that one of the values in the assert condition will be satisfied.
Tests:
com.github.jreddit.request.util.KeyValueFormatterTest.testFormatMultiple
com.github.jreddit.request.util.KeyValueFormatterTest.testFormatMultipleUTF8
com.github.jreddit.oauth.param.RedditScopeBuilderTest.testAddMultiple