Implemented revoke token in RedditOAuthAgent #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added code to post to https://www.reddit.com/api/v1/revoke_token in order to revoke the refresh_token or access_token depending on which is required.
The creation of the builder in the revoke method was found to be excessively long. It was extracted into a new method called createBuilder to carry out the same task. The ExampleVotingRequest has been run again to ensure that the functionality was unaffected.
|
Looks good in general, I don't have the time to pull and validate the method. Added small suggestion. Also add a test when the method fails and for the execution branches created by various input values? |
|
Hey! Thanks for reviewing this. I've made the changes you requested. For the tests, there are only really two test cases here since the api itself only returns a 401 if client authentication was incorrect or 202 in every other case, even if the token is not valid, or if it was revoked multiple times. |
In compliance with the instructor’s note to include a read me for the TAs, pushing a txt document that outlines the enhancements we made for this project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We implemented the revoke() function within the RedditOAuthAgent class. We've provided examples of how to revoke a token in the example files and we've written JUnit tests for the implemented functionality.