Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Build System #26

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

New Build System #26

wants to merge 12 commits into from

Conversation

krau612
Copy link
Collaborator

@krau612 krau612 commented May 18, 2016

I re-wrote the build.sh script to use uglifyjs to minify the javascript files, then use the "google-chrome --pack-extension" command to create the pem file, then I used a script from developer.chrome.com to create the crx file using the minified files and the pem file. Everything is then cleaned up.

This will only work if google-chrome and node-uglify are installed.

Sorry, it appears that either WebReg or one of the data dependencies for Planner Helper
have changed their format. An error report has been sent and an update will be released
soon to make Planner Helper compatible with these changes.`;
var message = "Sorry, it appears that either WebReg or one of the data dependencies for Planner Helper" +
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There needs to be a space at the end of this string or else the output will look like "...Planner Helperhave changed...". (same goes for line 197)

@j-delaney
Copy link
Owner

This is amazing! Thank you so much for working this. Since it adds google-chrome and node-uglify as dependencies could you also update the README to mention that (with how to install them as well)?

# This was taken from https://developer.chrome.com/extensions/crx

if test $# -ne 2; then
echo "Usage: crxmake.sh <extension dir> <pem path>"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this use createCRX.sh instead of crxmake.sh?

@krau612
Copy link
Collaborator Author

krau612 commented May 19, 2016

Ok I've updated with those fixes

@j-delaney
Copy link
Owner

Thanks! Sorry for forgetting to mention this earlier but could you also update the README with details on how to do the build (i.e. using build.sh and crxmake.sh properly)

@krau612
Copy link
Collaborator Author

krau612 commented May 19, 2016

No problem, the build instructions have been added

@j-delaney
Copy link
Owner

Sorry for the delay. I haven't gotten around to testing this yet. I'll test it and merge it this weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants