Add typings #104
Open
Add typings #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Selam, neden draft a aldiniz? |
|
Son versiyonun 3 yıl önce paylaşıldığı ve CI Pipeline'larında Node 3, 4, 5 bulunan bir kütüphaneye katkıda bulunmak biraz zor oluyor. Travis testlerini geçemeyeceğinden fazla uğraşmayı tercih etmedim. En son kullandığım halini paylaşıp bırakacağım. |
ouzkilic
approved these changes
Nov 15, 2022
ozalperen
approved these changes
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to fix #92 by adding new TypeScript typings to the library. I was trying to use the library with TypeScript when I realized there is no support for it. So I decided to implement new types for my project. This was for personal use only, decided to PR. ✨
Don't be afraid to criticize and please give constructive feedback, thank you!